-
Notifications
You must be signed in to change notification settings - Fork 224
Sdcpp vulkan integration #1084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
makn87amd
wants to merge
5
commits into
main
Choose a base branch
from
sdcpp_vulkan_integration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Sdcpp vulkan integration #1084
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
da3783b
Add Vulkan backend support for sd-cpp
makn87amd 426ff93
Add Vulkan to CLI validation and system detection
makn87amd f97e76a
Added sdcpp vulkan backend tests to CI workflow
makn87amd 582b35c
Removed claimed Linux support for sd-cpp vulkan backend
makn87amd 245c782
Merge branch 'main' into sdcpp_vulkan_integration
makn87amd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -120,6 +120,15 @@ static const std::vector<RecipeBackendDef> RECIPE_DEFS = { | |
| {"amd_dgpu", {"gfx110X", "gfx120X"}}, | ||
| }}, | ||
|
|
||
| // stable-diffusion.cpp - Vulkan backend (cross-platform GPU) | ||
| {"sd-cpp", "vulkan", {"windows"}, { | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please add Linux Vulkan: sd-master-636d3cb-bin-Linux-Ubuntu-24.04-x86_64-vulkan.zip |
||
| {"cpu", {"x86_64"}}, | ||
| {"amd_igpu", {}}, | ||
| {"amd_dgpu", {}}, | ||
| {"nvidia_dgpu", {}}, | ||
| {"intel_igpu", {}}, | ||
| }}, | ||
|
|
||
| // stable-diffusion.cpp - CPU backend (Windows/Linux x86_64) | ||
| {"sd-cpp", "cpu", {"windows", "linux"}, { | ||
| {"cpu", {"x86_64"}}, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should vulkan be the default over ROCm if its required for complex models to work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense.