Conversation
|
Waiting a few days to see if @jeremyfowers also wants to review this |
jeremyfowers
left a comment
jeremyfowers
left a comment
There was a problem hiding this comment.
Please resolve conflicts and then yes I'd like to test drive it before merging
|
Resolved conflicts. @jeremyfowers Please take a look. |
| @@ -1,4 +1,4 @@ | |||
| import React, { useEffect, useRef, useState } from 'react'; | |||
| import React, { useCallback, useEffect, useRef, useState } from 'react'; | |||
There was a problem hiding this comment.
What's up with all the WebSocketServer::handleConnection() HTTP status: 400 error: Missing Sec-WebSocket-Key value? Never seen that before.
| import React, { useEffect, useRef, useState } from 'react'; | ||
| import React, { useCallback, useEffect, useRef, useState } from 'react'; | ||
| import { getAPIKey, getServerBaseUrl, onServerUrlChange, serverConfig } from './utils/serverConfig'; | ||
| import {EventSource} from 'eventsource'; |
There was a problem hiding this comment.
Doesn't seem to work for Kokoro, SD, Whisper, or RyzenAI-Server?
The KokoroServer logs are ending up under Lemonade Router not Kokoro Server.
| @@ -7,6 +7,11 @@ interface LogsWindowProps { | |||
| height?: number; | |||
| } | |||
There was a problem hiding this comment.
Two instances of llama-server (under --max-loaded-models 2) share the same log view. Should it be clearly separated and labeled into llama-server[0] and [1]? Or better yet, filter by model name instead of process name?
jeremyfowers
left a comment
jeremyfowers
left a comment
There was a problem hiding this comment.
Sorry about the very long wait!
I like this PR conceptually @danielholanda but there seems to be a few bugs. The overall design is sound and I'd like this to be an app feature.
|
Awesome! Thanks for the review. Will take a second stab at it in the next few days |
|
Setting to draft until the requested changes are made. |
3 participants
Description
Backend subprocess logs are now tagged with their source name (llama-server, whisper-server, etc.) instead of a generic Process tag
Details