Fix libcurl timeout for large prompts#1421
Draft
james-martinez wants to merge 2 commits intolemonade-sdk:mainfrom
Draft
Fix libcurl timeout for large prompts#1421james-martinez wants to merge 2 commits intolemonade-sdk:mainfrom
james-martinez wants to merge 2 commits intolemonade-sdk:mainfrom
Conversation
…meout Co-authored-by: james-martinez <1388493+james-martinez@users.noreply.github.com>
james-martinez
changed the title
winmutt
reviewed
Mar 20, 2026
| const std::string& body, | ||
| const std::map<std::string, std::string>& headers = {}, | ||
| long timeout_seconds = 300); | ||
| long timeout_seconds = -1); |
There was a problem hiding this comment.
Why not add a configuration option per, with global as a default if not set and then a global default of 300s?
Also, under what conditions do we really even want timeouts?
Contributor
Author
There was a problem hiding this comment.
timeouts are configurable for safety and efficiency.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1364 where large prompts timed out exactly at 5 minutes due to the global timeout overriding the default behavior.
HttpClientto default to-1to fallback to default0to curl directly for infinite--global-timeoutto be minimum 300 or infinite