warning messages requested by the BIOS team#20
warning messages requested by the BIOS team#20sugudsl wants to merge 2 commits intolenovo:masterfrom
Conversation
| } else { | ||
| printf("BIOS Setting changed\n"); | ||
| printf("Setting will not change until reboot\n"); | ||
| printf("Please check whether the setting name is Valid\n"); |
| printf("BIOS Setting changed\n"); | ||
| printf("Setting will not change until reboot\n"); | ||
| printf("Please check whether the setting name is Valid\n"); | ||
| printf("please complete authentication if BIOS password is set\n"); |
| printf("Setting will not change until reboot\n"); | ||
| printf("Please check whether the setting name is Valid\n"); | ||
| printf("please complete authentication if BIOS password is set\n"); | ||
| printf("Do you want to continue (Y/N):"); |
There was a problem hiding this comment.
So I personally think the first 'warning' is pointless. If they're not using a valid name the call will fail, and they're not going to use an invalid name deliberately.
I would put the authentication warning if the set fails as a possible reason it fails. But it would be much better to probe the interface to confirm if admin password is set and to print this message if it's required. Blindly printing it everytime is just annoying.
Consider adding a flag to skip the continue check - adding this will make scripting thinklmi harder.
There was a problem hiding this comment.
Removed the first warning.
Probing and printing the warning only if the password is set, will take it as an improvement for the next release.
Removed the Y/N check for setting the setting. Retained for the TPM type change
| } else { | ||
| printf("BIOS Setting changed\n"); | ||
| printf("Setting will not change until reboot\n"); | ||
| } |
There was a problem hiding this comment.
Your indentation in the above looks wonky - check your editor settings.
There was a problem hiding this comment.
My vim editor displays this correctly, however there a tab, which I removed
|
|
||
| printf("Before switching TPM, please make sure the TPM is not in use and all TPM related applications\n"); | ||
| printf("must be disabled, otherwise the TPM will be cleared and you may not be able to access your data\n"); | ||
| printf("\n Do you wish to continue(Y/N):"); |
There was a problem hiding this comment.
As above - consider adding a nocheck option to bypass the continue check for easier scripting
| } else { | ||
| printf("Tpm type changed\n"); | ||
| printf("Setting will not change until reboot\n"); | ||
| } |
There was a problem hiding this comment.
Tpm in the above perrors should be capitalised (TPM)
2 participants
No description provided.