Invoke INavigationAware callbacks on UI thread (#1307)

lepoco · Feb 1, 2025 · 1e4fe2a · 1e4fe2a
1 parent 58f3e36
commit 1e4fe2a
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 48 deletions.
diff --git a/samples/Wpf.Ui.Demo.Mvvm/ViewModels/ViewModel.cs b/samples/Wpf.Ui.Demo.Mvvm/ViewModels/ViewModel.cs
@@ -10,11 +10,11 @@ namespace Wpf.Ui.Demo.Mvvm.ViewModels;
 public abstract class ViewModel : ObservableObject, INavigationAware
 {
     /// <inheritdoc />
-    public virtual async Task OnNavigatedToAsync()
+    public virtual Task OnNavigatedToAsync()
     {
-        using CancellationTokenSource cts = new();
+        OnNavigatedTo();
 
-        await DispatchAsync(OnNavigatedTo, cts.Token);
+        return Task.CompletedTask;
     }
 
     /// <summary>
@@ -24,32 +24,16 @@ public virtual async Task OnNavigatedToAsync()
     public virtual void OnNavigatedTo() { }
 
     /// <inheritdoc />
-    public virtual async Task OnNavigatedFromAsync()
+    public virtual Task OnNavigatedFromAsync()
     {
-        using CancellationTokenSource cts = new();
+        OnNavigatedFrom();
 
-        await DispatchAsync(OnNavigatedFrom, cts.Token);
+        return Task.CompletedTask;
     }
 
     /// <summary>
     /// Handles the event that is fired before the component is navigated from.
     /// </summary>
     // ReSharper disable once MemberCanBeProtected.Global
     public virtual void OnNavigatedFrom() { }
-
-    /// <summary>
-    /// Dispatches the specified action on the UI thread.
-    /// </summary>
-    /// <param name="action">The action to be dispatched.</param>
-    /// <param name="cancellationToken">A cancellation token that can be used to cancel the operation.</param>
-    /// <returns>A task that represents the asynchronous operation.</returns>
-    protected static async Task DispatchAsync(Action action, CancellationToken cancellationToken)
-    {
-        if (cancellationToken.IsCancellationRequested)
-        {
-            return;
-        }
-
-        await Application.Current.Dispatcher.InvokeAsync(action);
-    }
 }
diff --git a/src/Wpf.Ui.Gallery/ViewModels/ViewModel.cs b/src/Wpf.Ui.Gallery/ViewModels/ViewModel.cs
@@ -8,11 +8,11 @@ namespace Wpf.Ui.Gallery.ViewModels;
 public abstract partial class ViewModel : ObservableObject, INavigationAware
 {
     /// <inheritdoc />
-    public virtual async Task OnNavigatedToAsync()
+    public virtual Task OnNavigatedToAsync()
     {
-        using CancellationTokenSource cts = new();
+        OnNavigatedTo();
 
-        await DispatchAsync(OnNavigatedTo, cts.Token);
+        return Task.CompletedTask;
     }
 
     /// <summary>
@@ -22,32 +22,16 @@ public virtual async Task OnNavigatedToAsync()
     public virtual void OnNavigatedTo() { }
 
     /// <inheritdoc />
-    public virtual async Task OnNavigatedFromAsync()
+    public virtual Task OnNavigatedFromAsync()
     {
-        using CancellationTokenSource cts = new();
+        OnNavigatedFrom();
 
-        await DispatchAsync(OnNavigatedFrom, cts.Token);
+        return Task.CompletedTask;
     }
 
     /// <summary>
     /// Handles the event that is fired before the component is navigated from.
     /// </summary>
     // ReSharper disable once MemberCanBeProtected.Global
     public virtual void OnNavigatedFrom() { }
-
-    /// <summary>
-    /// Dispatches the specified action on the UI thread.
-    /// </summary>
-    /// <param name="action">The action to be dispatched.</param>
-    /// <param name="cancellationToken">A cancellation token that can be used to cancel the operation.</param>
-    /// <returns>A task that represents the asynchronous operation.</returns>
-    protected static async Task DispatchAsync(Action action, CancellationToken cancellationToken)
-    {
-        if (cancellationToken.IsCancellationRequested)
-        {
-            return;
-        }
-
-        await Application.Current.Dispatcher.InvokeAsync(action);
-    }
 }
diff --git a/src/Wpf.Ui/Controls/NavigationView/NavigationViewContentPresenter.cs b/src/Wpf.Ui/Controls/NavigationView/NavigationViewContentPresenter.cs
@@ -211,27 +211,32 @@ private static void NotifyContentAboutNavigatingFrom(object content)
     )]
     private static void NotifyContentAboutNavigating(object content, Func<INavigationAware, Task> function)
     {
+        async void PerformNotify(INavigationAware navigationAware)
+        {
+            await function(navigationAware).ConfigureAwait(false);
+        }
+
         switch (content)
         {
             // The order in which the OnNavigatedToAsync/OnNavigatedFromAsync methods of View and ViewModel are called
             // is not guaranteed
             case INavigationAware navigationAwareNavigationContent:
-                _ = Task.Run(() => function(navigationAwareNavigationContent)).ConfigureAwait(false);
+                PerformNotify(navigationAwareNavigationContent);
                 if (
                     navigationAwareNavigationContent
                         is FrameworkElement { DataContext: INavigationAware viewModel }
                     && !ReferenceEquals(viewModel, navigationAwareNavigationContent)
                 )
                 {
-                    _ = Task.Run(() => function(viewModel)).ConfigureAwait(false);
+                    PerformNotify(viewModel);
                 }
 
                 break;
             case INavigableView<object> { ViewModel: INavigationAware navigationAwareNavigableViewViewModel }:
-                _ = Task.Run(() => function(navigationAwareNavigableViewViewModel)).ConfigureAwait(false);
+                PerformNotify(navigationAwareNavigableViewViewModel);
                 break;
             case FrameworkElement { DataContext: INavigationAware navigationAwareCurrentContent }:
-                _ = Task.Run(() => function(navigationAwareCurrentContent)).ConfigureAwait(false);
+                PerformNotify(navigationAwareCurrentContent);
                 break;
         }
     }