Skip to content

Commit

Permalink
fix: remove all non-analyzer warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
JohnTasler committed Feb 2, 2025
1 parent bb560af commit 1e709b6
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 17 deletions.
1 change: 1 addition & 0 deletions src/Wpf.Ui.Abstractions/Wpf.Ui.Abstractions.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
<Description>Abstractions for the WPF UI.</Description>
<CommonTags>$(CommonTags);abstractions;standard</CommonTags>
<_SilenceIsAotCompatibleUnsupportedWarning>true</_SilenceIsAotCompatibleUnsupportedWarning>
</PropertyGroup>

<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
<Description>Dependency injection for the WPF UI.</Description>
<CommonTags>$(CommonTags);dependency;injection;abstractions;standard</CommonTags>
<_SilenceIsAotCompatibleUnsupportedWarning>true</_SilenceIsAotCompatibleUnsupportedWarning>
</PropertyGroup>

<ItemGroup>
Expand Down
22 changes: 8 additions & 14 deletions src/Wpf.Ui/Controls/Arc/Arc.cs
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,14 @@ public class Arc : Shape
new PropertyMetadata(SweepDirection.Clockwise, PropertyChangedCallback)
);

/// <summary>Identifies the <see cref="StrokeStartLineCap"/> dependency property.</summary>
public static readonly DependencyProperty StrokeStartLineCapProperty = DependencyProperty.Register(
nameof(StrokeStartLineCap),
typeof(PenLineCap),
typeof(Arc),
new PropertyMetadata(PenLineCap.Round, PropertyChangedCallback)
);
static Arc()
{
// Modify the metadata of the StrokeStartLineCap dependency property.
StrokeStartLineCapProperty.OverrideMetadata(
typeof(Arc),
new PropertyMetadata(PenLineCap.Round, PropertyChangedCallback));

}

/// <summary>
/// Gets or sets the initial angle from which the arc will be drawn.
Expand Down Expand Up @@ -87,13 +88,6 @@ public SweepDirection SweepDirection
set => SetValue(SweepDirectionProperty, value);
}

// TODO: Should we?
public new PenLineCap StrokeStartLineCap
{
get { return (PenLineCap)GetValue(StrokeStartLineCapProperty); }
set { SetValue(StrokeStartLineCapProperty, value); }
}

/// <summary>
/// Gets a value indicating whether one of the two larger arc sweeps is chosen; otherwise, if is <see langword="false"/>, one of the smaller arc sweeps is chosen.
/// </summary>
Expand Down
6 changes: 3 additions & 3 deletions src/Wpf.Ui/Controls/Snackbar/SnackbarPresenter.cs
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ public virtual void AddToQue(Snackbar snackbar)

if (Content is null)
{
ShowQueuedSnackbars(); // TODO: Fix detached process
_ = ShowQueuedSnackbarsAsync(); // TODO: Fix detached process
}
}

Expand All @@ -86,7 +86,7 @@ public virtual async Task ImmediatelyDisplay(Snackbar snackbar)
await HideCurrent();
await ShowSnackbar(snackbar);

await ShowQueuedSnackbars();
await ShowQueuedSnackbarsAsync();
}

public virtual async Task HideCurrent()
Expand All @@ -101,7 +101,7 @@ public virtual async Task HideCurrent()
ResetCancellationTokenSource();
}

private async Task ShowQueuedSnackbars()
private async Task ShowQueuedSnackbarsAsync()
{
while (Queue.Count > 0 && !CancellationTokenSource.IsCancellationRequested)
{
Expand Down

0 comments on commit 1e709b6

Please sign in to comment.