Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS scroll state container queries #4311

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

puckowski
Copy link
Contributor

What:

Add Less.js support for container queries to style descendants of containers based on their scroll state.

Why:

Container query scroll state support is available in Chrome 133 (https://developer.chrome.com/blog/chrome-133-beta). Getting ahead of broader support. Without this PR the Less.js output of scroll-state is incorrect.

Checklist:

  • Documentation
  • Added/updated unit tests
  • Code complete

* Add support for CSS container query scroll-state.
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 17, 2025
@iChenLei iChenLei requested a review from matthew-dean January 19, 2025 12:30
@matthew-dean
Copy link
Member

@puckowski What's the state of this? Where you going to refactor it?

* Fixes issue with scroll-state function not being detected by regex.
@puckowski
Copy link
Contributor Author

Thank you for the ping.

Pulled latest master to avoid CI issues and applied fixes (no more space between scroll-state and parenthesis (). I believe this is in a good position to merge now.

@matthew-dean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants