LCM-1051-change-logic-for-initializing-grant-object #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inittion has changed
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| when ActiveRecord::Base | ||
| actor | ||
|
|
||
| if actor.is_a?(ActiveRecord::Base) |
There was a problem hiding this comment.
Style/GuardClause: Use a guard clause instead of wrapping the code inside a conditional expression.
nathan-salazar
commented
Oct 8, 2025
| matrix: | ||
| os: [ubuntu-latest] | ||
| ruby: ["2.6", "2.7", "3.0"] | ||
| ruby: ["2.7", "3.0", "3.1", "3.2"] |
Contributor
Author
There was a problem hiding this comment.
Ruby 2.6 tests were failing due to an incompatibility with ActiveSupport 6.1. Plus, its EOL was in 2022 so I figured we're safe to stop supporting it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Resolves LCM-1051
In Rails 7.1 they removed an override of the
===operator (specifically, this was removed in 7.1). This ultimately affects the waycasestatements work.Now that we have introduced
SeismicUserandSeismicGroupin the core app, the case statement is failing. Explicitly using theis_a?method not only makes this more clear, but also preserves the original logic.What?
Changes the
casestatement (which implicitly relies on===) to anif/elsethat uses theis_a?method.Further Reading
===method rails/rails#55870Merge Instructions
Please DO squash my commits when merging