Skip to content

LCM-1051-change-logic-for-initializing-revoke-object #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nathan-salazar merged 2 commits into from
Oct 8, 2025
Merged

LCM-1051-change-logic-for-initializing-revoke-object #48

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2bc9071
swap case statement for if/else
nathan-salazar Oct 8, 2025
ef12cbd
fix error type
nathan-salazar Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/accessly/permission/revoke.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@ class Revoke < Accessly::Base
# @param actor [ActiveRecord::Base] The actor to revoke permission
def initialize(actor)
super(actor)
@actor = case actor
when ActiveRecord::Base
actor

if actor.is_a?(ActiveRecord::Base)
Copy link

@hound hound bot Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/GuardClause: Use a guard clause instead of wrapping the code inside a conditional expression.

@actor = actor
else
raise Accessly::RevokeError.new("Actor is not an ActiveRecord::Base object")
raise Accessly::GrantError.new("Actor is not an ActiveRecord::Base object")
end
end

Expand Down
Loading