Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for $pull #45

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Add support for $pull #45

merged 1 commit into from
Apr 2, 2024

Conversation

desavitsky
Copy link
Contributor

@oolong/maintainers

desavitsky
desavitsky commented Apr 1, 2024
View reviewed changes
oolong-mongo/src/test/scala/oolong/mongo/UpdateSpec.scala
Comment on lines +256 to +257
"$pull" -> BsonDocument(
"listField" -> BsonDocument("$eq" -> BsonInt32(2)) // TODO: think about having here a value instead of a condition
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, worth revisiting later, I think

@desavitsky desavitsky merged commit d564cb8 into main Apr 2, 2024
5 checks passed
@danslapman danslapman deleted the dsavitsky/pull branch April 2, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Assassin4791 Assassin4791 Assassin4791 approved these changes

@edubrovski edubrovski Awaiting requested review from edubrovski edubrovski is a code owner

@danslapman danslapman Awaiting requested review from danslapman danslapman is a code owner

@InversionSpaces InversionSpaces Awaiting requested review from InversionSpaces InversionSpaces is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@desavitsky @Assassin4791