Generalize custom transformer code by loading from DB #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
This was referenced Oct 9, 2023
jnnnthnn
commented
Oct 9, 2023
| name="query_embeddings", | ||
| description="Query for similar documents") | ||
| async def query_embeddings(query_string: str, k: int = 5, session: AsyncSession = Depends(get_session)) -> dict: | ||
| transformer_result = await session.execute(select(Transformer).where(Transformer.transformer_id == "text.embeddings.minilm")) |
Contributor
Author
There was a problem hiding this comment.
Note I'm hard-coding text.embeddings.minilm for now. That is changed upstack.
| description="Query for similar documents") | ||
| async def query_embeddings(query_string: str, k: int = 5, session: AsyncSession = Depends(get_session)) -> dict: | ||
| transformer_result = await session.execute(select(Transformer).where(Transformer.transformer_id == "text.embeddings.minilm")) | ||
| transformer = transformer_result.scalar_one() |
Contributor
Author
There was a problem hiding this comment.
This will raise if it fails. We can catch and rethrow a custom error to improve DX.
| return {"Say": "Transformer deleted!"} | ||
|
|
||
|
|
||
| @router.post("/embed/string", |
Contributor
Author
There was a problem hiding this comment.
I don't think it's worth maintaining this?
| regex=r"^[a-zA-Z][a-zA-Z0-9_.]+$" | ||
| ) | ||
| path: Optional[str] = Field( | ||
| code: str = Field( |
Contributor
Author
There was a problem hiding this comment.
You will need to reset your DB state as a result of this (at least by deleting the bindings and transformers models)!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
Generalizes custom transformer code by loading from DB.
Why
We want users to be able to provide arbitrary code to be run as transformers. To that end, we need the ability to run said arbitrary code. This PR scaffolds a minimal viable way to load said code.
Test plan
Call each of the affected endpoints (
/embeddings/queryand/indexes/{index_id}/records/query) and confirm their behavior is unchanged.