Support Remote-console and Edgeview-UI VNC for eve-k

[naiming-zededa]

Description

• support edgeview command passing App-UUID for virtctl to launch VNC proxy to be used for Edgeview-UI VNC and remote-console
• have consolidated scheme for both remote-console and edgeview-ui VNC signaling file and launch

PR dependencies

How to test and validate this PR

• before the controller side to add support for this feature, can test the App remote-console for eve-k VMI access
• after the controller side have implemented, can also use Edgeview-UI access VNC to the eve-k VMI

Changelog notes

Support Remote-console and Edgeview-UI VNC for eve-k

PR Backports

Checklist

• I've provided a proper description
• I've added the proper documentation
• I've tested my PR on amd64 device
• I've tested my PR on arm64 device
• I've written the test verification instructions
• I've set the proper labels to this PR

For backport PRs (remove it if it's not a backport):

• I've added a reference link to the original PR
• PR's title follows the template

And the last but not least:

• I've checked the boxes above, or I've provided a good reason why I didn't
  check them.

Please, check the boxes above after submitting the PR in interactive mode.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 29.49%. Comparing base (2281599) to head (9c59fd8).
⚠️ Report is 273 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5598      +/-   ##
==========================================
+ Coverage   19.52%   29.49%   +9.96%     
==========================================
  Files          19       18       -1     
  Lines        3021     2417     -604     
==========================================
+ Hits          590      713     +123     
+ Misses       2310     1552     -758     
- Partials      121      152      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[shjala]

Should implement remote_access_disabled for this one too?

[naiming-zededa]

Should implement remote_access_disabled for this one too?

Since the traditional 'remote-console' access is not controlled by this remote_access_disabled file, I assume this file is for the device side user access only. This patch is only for the eve-k version of the implementation.

[shjala]

@naiming-zededa If remote access is disabled, meaning remote_access_disabled exist, we should disable all sorts of remote access, currently it has effect on ssh and edgeview in general, I assume having remote_access_disabled would disable edge-view in the first place so user can't "use Edgeview-UI access VNC to the eve-k VMI".

Am I correct? If that is the case, then there is no need to add anything extra.

[naiming-zededa]

@naiming-zededa If remote access is disabled, meaning remote_access_disabled exist, we should disable all sorts of remote access, currently it has effect on ssh and edgeview in general, I assume having remote_access_disabled would disable edge-view in the first place so user can't "use Edgeview-UI access VNC to the eve-k VMI".

Am I correct? If that is the case, then there is no need to add anything extra.

This is not the case in the current Edgeview implementation. This is more than just Edgeview VNC access. If we want to do that, then it can be a separate task. Please generate an issue or ticket on this requirement.

[shjala]

This is not the case in the current Edgeview implementation. This is more than just Edgeview VNC access. If we want to do that, then it can be a separate task. Please generate an issue or ticket on this requirement.

You are right, by design we don't block controller-authorized remote session, nothing to be done regarding the remote_access_disabled .

[zedi-pramodh]

@milan-zededa please help review this PR.