eve-k: set longhorn node-down-pod-deletion-policy#5603
Draft
andrewd-zededa wants to merge 1 commit intolf-edge:masterfrom
Draft
eve-k: set longhorn node-down-pod-deletion-policy#5603andrewd-zededa wants to merge 1 commit intolf-edge:masterfrom
andrewd-zededa wants to merge 1 commit intolf-edge:masterfrom
Conversation
github-actions
bot
requested review from
eriknordmark,
naiming-zededa and
zedi-pramodh
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5603 +/- ##
==========================================
+ Coverage 19.52% 29.49% +9.96%
==========================================
Files 19 18 -1
Lines 3021 2417 -604
==========================================
+ Hits 590 713 +123
+ Misses 2310 1552 -758
- Partials 121 152 +31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Only question I have is since we are copying into manifests directory, does it cause lots of logs messages if longhorn gets deleted in zks environment? |
Contributor
Author
cluster-init.sh line 1387 will remove it for base_mode. |
For app failover performance optimization. Move this and upgrade-checker into common config yaml instead of patch command. Signed-off-by: Andrew Durbin <andrewd@zededa.com>
andrewd-zededa
force-pushed
the
eve-k-lh-cfg
branch
from
e678ffd to
3c6d706
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For app failover performance optimization.
Move this and upgrade-checker into common config
yaml instead of patch command.
PR dependencies
None
How to test and validate this PR
kubectl -n longhorn-system get settings.longhorn.io/node-down-deletion-policyreports delete-both-statefulset-and-deployment-podChangelog notes
Optimize app failover speeds
PR Backports
Checklist
And the last but not least:
check them.
Please, check the boxes above after submitting the PR in interactive mode.