Fix linter warnings in shell scripts and Dockerfile syntax #5607
Open
rucoder wants to merge 3 commits intolf-edge:masterfrom
Open
Fix linter warnings in shell scripts and Dockerfile syntax #5607rucoder wants to merge 3 commits intolf-edge:masterfrom
rucoder wants to merge 3 commits intolf-edge:masterfrom
Conversation
ENV must have '=' in assignment and lists must be "'ed NOTE: there is a false-positive hadolint warning due to hadolint/hadolint#951 - packages affected pkg/dom0-ztools pkg/xen-tools Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>
- use $() instead of `` - fix shellcheck: note: Double quote to prevent globbing and word splitting. [SC2086] Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>
rucoder
requested review from
OhmSpectator and
Copilot
and removed request for
rene,
rouming and
shjala
github-actions
bot
requested review from
christoph-zededa,
eriknordmark,
rene,
rouming and
shjala
rucoder
requested review from
shjala
and removed request for
christoph-zededa,
eriknordmark,
rouming and
shjala
There was a problem hiding this comment.
Pull request overview
This pull request addresses linter warnings in shell scripts and Dockerfiles by modernizing syntax and improving code quality. The changes are purely cosmetic and do not affect functionality. They convert deprecated backtick command substitution to modern $() syntax, add proper variable quoting for safety, standardize Dockerfile ENV declarations to use equals signs, and fix multi-line command indentation.
Changes:
- Converted backtick command substitution to modern
$()syntax in shell scripts - Added quotes around shell variables in command arguments for safety
- Standardized Dockerfile ENV variable declarations to use
ENV VAR=valuesyntax - Fixed multi-line command indentation in Dockerfile for better readability
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/xen-tools/initrd/init-initrd | Modernized shell syntax by converting backticks to $() and adding variable quotes |
| pkg/xen-tools/Dockerfile | Standardized ENV syntax with equals signs and fixed multi-line command indentation |
| pkg/dom0-ztools/rootfs/etc/init.d/010-eve-cgroup | Converted backtick to $() for command substitution |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- previous commit changes a hash for eve-dom0-ztools so we must update all references to it Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>
rucoder
force-pushed
the
rucoder/linter-fixes-1
branch
from
775a1e9 to
324f78b
Compare
rene
approved these changes
Feb 14, 2026
Contributor
Author
|
@rene go tests are irrelevant here, I'll fix them in another PR. we can merge I think |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix linter warnings in shell scripts and Dockerfile syntax
NOTE: there will be a false-positive hadolint warning due to hadolint/hadolint#951
PR dependencies
None
How to test and validate this PR
run yetus
Changelog notes
None
PR Backports
Not required. cosmetic change
Checklist
I've provided a proper description
I've added the proper documentation
I've tested my PR on amd64 device
I've tested my PR on arm64 device
I've written the test verification instructions
I've set the proper labels to this PR
I've checked the boxes above, or I've provided a good reason why I didn't
check them.
Please, check the boxes above after submitting the PR in interactive mode.