Allow cross-origin connections to websocket #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 14, 2020 19:09
Changed deprecated call to ioutil into a new call direcly on the os package. Removed unreachable code. Changed string conversion function to a newer one that has proper error handling when conversion fails.
Removed usages of deprecated functions. Removed redundant type declarations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This is just a tiny pull-request to allow cross-origin connections to the websocket to fetch data. The code already adds cors headers for HTTP-requests, but the websocket library has it's own internal blocking mechanism that can be overridden by passing your own callback. I don't know if I've done this in an optimal way. This is my very first time playing around with Go code.
I have been playing around with my own map front-end that is a bit like a "virtual guide" that fetches Wikipedia articles from around you and reads them out loud using text-to-speech. To use it cross-origin connections need to be allowed. The map front-end I've been working on can be found at https://kivle.github.io/msfs-map and you can check out the code at https://github.com/kivle/msfs-map. I've built it using create-react-app and react-leaflet. Run vfrmap from this branch and then just open the map. It should automatically connect to ws://localhost:9000/ws.