make sure all configs written in snapshot have same, latest, step size #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure all configs written in snapshot have same, latest, step size. And add check for consistent step sizes when distributing initial configurations. Add pytest that times out when original bug is present.
bernstei
force-pushed
the
snapshot_wrong_step_sizes
branch
from
c8e1ddb to
da5bc91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue that configs on non-head MPI task had wrong (old) step sizes. Initial fix is to copy current step size into buffer used to write configs during snapshot. Reason for hang is subtle, since code appears to depend only on values that are the same on all MPI tasks.
Additional steps that might be worth it
closes #20