Fix bug in step size tuning having to do with order of attempt/successs counts #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s counts Switch to keeping track of step_size parameters and attempt/success statistics in dicts, rather than arrays, to reduce chance of inconsistencies in the order, which are what caused #24
Collaborator
Author
|
@VGFletcher is this (or #27, which I believe includes these changes) working for you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to keeping track of step_size parameters and attempt/success statistics in dicts, rather than arrays, to reduce chance of inconsistencies in the order.
[may want to add a test that fails under the previous behavior]
closes #24