Skip to content

CONSENSUS: v1 subscripting ob1. #1768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evoskuil merged 1 commit into from
Dec 6, 2025
Merged

CONSENSUS: v1 subscripting ob1. #1768

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/chain/transaction_sighash_v1.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,17 +41,17 @@ namespace chain {

// static
// Zero-based opcode position of the last executed op_codeseparator before
// currently executed signature opcode (0xffffffff if none) [bip342].
// currently executed signature opcode (0xffffffff if none) [bip342]. Previous
// versions require the next opcode, but this requires the position. Since the
// op_codeseparator implementation sets offset to next, it must be decremented.
uint32_t transaction::subscript_v1(const script& script) NOEXCEPT
{
if (script.ops().empty())
return chain::default_separators;

const auto start = script.ops().begin();
const auto span = std::distance(start, script.offset);
const auto slot = possible_narrow_and_sign_cast<uint32_t>(span);
const auto none = is_zero(slot) && start->code() != opcode::codeseparator;
return none ? chain::default_separators : slot;
const auto next = std::distance(script.ops().begin(), script.offset);
return is_zero(next) ? chain::default_separators :
possible_narrow_and_sign_cast<uint32_t>(sub1(next));
}

// ext_flags and annex flag are combined into one byte, who knows why.
Expand Down
Loading