Repository navigation
bpftool: update submodule for newer glibc headers - #378
Merged
Merged
Conversation
Collaborator
|
CI is still failing. Can you take a look at the issue? |
Contributor
Author
Found the CI failure: bpftool compiles bootstrap/sign.c, which requires openssl/opensslv.h. Added libssl-dev to the Ubuntu build image in 95449ca. The Docker daemon is unavailable on my host, so I could not build the image locally. |
danielocfb
approved these changes
Oct 21, 2026
danielocfb
left a comment
danielocfb
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me, thanks.
Collaborator
|
Can you please merge the two commits and we can get this in. |
Update bpftool and install OpenSSL development headers in CI so its cryptographic support can be built alongside the glibc compatibility fix. Signed-off-by: Eduard Zateev <hackerowskiy@gmail.com>
sairex53
force-pushed
the
fix/bpftool-modern-libc
branch
from
October 22, 2026 14:16
95449ca to
0cf45d5
Compare
Contributor
Author
Squashed the two commits into one. The resulting file tree is unchanged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bundled bpftool uses an old libbpf revision whose
resolve_full_path()assignsstrchr()'s result to a non-const pointer. With newer glibc headers, this fails with-Werror=discarded-qualifiers.Update the bpftool submodule to
3e1a35a, which includes the upstream libbpf correction. This changes only the bpftool gitlink.Fixes #373.
Validation on Fedora 44 aarch64 (GCC 16.2.1, Clang 22.1.8):
make -C examples/c clean && make -C examples/c -j2.examples/cwith CMake 4.3.profile, built successfully with both build systems; both builds use the bundled bpftool and default warning settings.