Skip to content

cmake: compare Clang major version numerically - #380

Merged
danielocfb merged 1 commit into
libbpf:masterfrom
sairex53:fix/cmake-clang-version-check
Oct 20, 2026
Merged

danielocfb merged 1 commit into
libbpf:masterfrom
sairex53:fix/cmake-clang-version-check

Conversation

@sairex53

Copy link
Copy Markdown
Contributor

Summary

Use a numeric comparison for the minimum supported Clang major version. The previous string comparison accepted versions 8 and 9 even though the module requires Clang 10 or newer.

Validation

  • Configured the CMake module with controlled Clang version strings: 8 and 9 were rejected; 10, 11, and 22 were accepted.
  • git diff --check

Signed-off-by: Eduard Zateev <hackerowskiy@gmail.com>
@danielocfb

Copy link
Copy Markdown
Collaborator

The previous string comparison accepted versions 8 and 9 even though the module requires Clang 10 or newer.

lol...

I guess this is fine, thanks.

@danielocfb
danielocfb merged commit 1aa2059 into libbpf:master Oct 20, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants