src/check_run.c: fix build on noMMU platforms #354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/check_run.c defines sig_handler() under the following conditions: #if defined(HAVE_FORK) && HAVE_FORK==1 however, it does use sig_handler under the following conditions: #if defined(HAVE_SIGACTION) && defined(HAVE_FORK) which breaks when HAVE_FORK is defined, but has the value HAVE_FORK=0, as is the case on noMMU platforms. This commit fixes this by ensuring that the build conditions are aligned throughout check_run.c. Fixes: src/check_run.c: In function 'srunner_run_tagged': src/check_run.c:802:38: error: 'sig_handler' undeclared (first use in this function); did you mean 'sa_handler'? [...] Signed-off-by: Thomas Petazzoni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/check_run.c defines sig_handler() under the following conditions:
#if defined(HAVE_FORK) && HAVE_FORK==1
however, it does use sig_handler under the following conditions:
#if defined(HAVE_SIGACTION) && defined(HAVE_FORK)
which breaks when HAVE_FORK is defined, but has the value HAVE_FORK=0, as is the case on noMMU platforms.
This commit fixes this by ensuring that the build conditions are aligned throughout check_run.c.
Fixes:
src/check_run.c: In function 'srunner_run_tagged': src/check_run.c:802:38: error: 'sig_handler' undeclared (first use in this function); did you mean 'sa_handler'? [...]