Skip to content

Conversation

MickaelOnTheWave
Copy link

Added fann include directory to public include directories.
Thus, projects using it can automatically include headers from fann.

Copy link
Member

@bukka bukka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement, thanks.

I think it should probably remove INCLUDE_DIRECTORIES(${CMAKE_CURRENT_SOURCE_DIR}/include) on line 15, right?

ADD_LIBRARY(fann SHARED ${fann_LIB_SRCS})
target_include_directories(fann PUBLIC ${CMAKE_CURRENT_SOURCE_DIR}/include)
ADD_LIBRARY(fann_static STATIC ${fann_LIB_SRCS})
target_include_directories(fann PUBLIC ${CMAKE_CURRENT_SOURCE_DIR}/include)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
target_include_directories(fann PUBLIC ${CMAKE_CURRENT_SOURCE_DIR}/include)
target_include_directories(fann_static PUBLIC ${CMAKE_CURRENT_SOURCE_DIR}/include)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants