Simplify getting dirty files in repository #2004
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple PR to help getting the dirty files in the repository.
Background: When getting a
RepositoryStatus
, we can use theIsDirty
property to tell if the repository is dirty.However, we don't have the same convenience to get the list of those dirty files.
Indeed, getting the actual list of dirty files would imply some duplicated logic in the client code, the same code that is present in the
RepositoryStatus
ctor to initialize theIsDirty
prop.What I propose is two parts (and 2 independent commits):
Most importantly, we move the
IsDirty
detection inside a StatusEntry, by adding a property of the same name. Before, the detection was done inside theRepositoryStatus
ctor, analyzing each StatusEntryFileStatus
. Now each StatusEntry has the responsibility of telling whether it is dirty.Least importantly, but I think it's nice, we add a
Dirty
collection insideRepositoryStatus
, that is initialized with all theIsDirty
StatusEntriesBefore thos changes, a client code working with dirty files could look like this:
With those two modifications, the client code would look like this:
I appreciate any feedback, let me know if anything need to be changed.