Adjust variance implementation and add new default hybrid algorithm #465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmh530
force-pushed
the
update_variance
branch
from
5e67136 to
9308465
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes some adjustments to how variance is implemented and the unit tests and coverage. The more significant change is a new default hybrid algorithm that combines the nice parts about the twoPass and online algorithm. For the purpose of the variance calculation, it is basically the same as twoPass, but offers more flexibility for VarianceAccumulator.
The online algorithm turns out to be much slower than I expected in benchmarks.