Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

interop: add electron transport interop ping test #1942

Open
p-shahi opened this issue Aug 7, 2023 · 3 comments · May be fixed by #3036
Open

interop: add electron transport interop ping test #1942

p-shahi opened this issue Aug 7, 2023 · 3 comments · May be fixed by #3036
Labels
good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/test Testing work

Comments

@p-shahi
Copy link
Member

p-shahi commented Aug 7, 2023

node.js/electron support for webrtc transport was added in #1905 & supports:

  • Dialing private-to-private
  • Listening private-to-private
  • Dialing private-to-public

Currently blocked on the fact that all WebRTC tests are disabled: #1846
@p-shahi p-shahi added P1 High: Likely tackled by core team if no one steps up status/blocked Unable to be worked further until needs are met labels Aug 7, 2023
@achingbrain
Copy link
Member

achingbrain commented Feb 25, 2025 •
edited
Loading

This is unblocked now. WebRTC/WebRTC Direct tests are run against node.js already but not electron.

Electron should run the same suite of transport tests as node.js.

To implement this:

  1. Create an ElectronDockerfile similar to https://github.com/libp2p/js-libp2p/blob/main/interop/BrowserDockerfile
  2. Build the electron container in https://github.com/libp2p/js-libp2p/blob/main/interop/Makefile
  3. Create an electron-version.json similar to https://github.com/libp2p/js-libp2p/blob/main/interop/node-version.json
  4. Add it to extra-versions - https://github.com/libp2p/js-libp2p/blob/main/.github/workflows/main.yml#L236

@achingbrain achingbrain added help wanted Seeking public contribution on this issue good first issue Good issue for new contributors kind/test Testing work and removed P1 High: Likely tackled by core team if no one steps up status/blocked Unable to be worked further until needs are met labels Feb 25, 2025
@achingbrain achingbrain changed the title interop: add node.js/electron WebRTC transport interop ping test interop: add electron transport interop ping test Feb 25, 2025
@sumanjeet0012
Copy link

@achingbrain I want to work on this Issue.

@achingbrain
Copy link
Member

Great, please submit a PR!

@sumanjeet0012 sumanjeet0012 linked a pull request Mar 6, 2025 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/test Testing work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: Add Electron Transport Interop Ping Test sumanjeet0012/js-libp2p
4 participants
@achingbrain @maschad @p-shahi @sumanjeet0012