Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add Electron Transport Interop Ping Test #3036

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

sumanjeet0012
Copy link

@sumanjeet0012 sumanjeet0012 commented Mar 6, 2025

Title

test: Add Electron Transport Interop Ping Test

Description

Closes #1942
This PR addresses the issue #1942 by adding interop ping tests for the Electron transport.

The changes made in the code are as follows :

  1. Electron Dockerfile: Created an ElectronDockerfile based on the existing BrowserDockerfile.
  2. Build Process: Updated the Makefile to build the Electron container.
  3. Version Configuration: Added electron-version.json to manage Electron versioning.
  4. Workflow Update: Integrated the Electron version into the extra-versions section of the GitHub Actions workflow.

Notes & open questions

If secureChannels and muxers in the electron-version.json file have incorrect values, please let me know where I can obtain the correct values.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@sumanjeet0012 sumanjeet0012 requested a review from a team as a code owner March 6, 2025 08:54
@sumanjeet0012
Copy link
Author

@achingbrain I have created the PR. Please review it.

@sumanjeet0012 sumanjeet0012 changed the title Feat: Add Electron Transport Interop Ping Test test: Add Electron Transport Interop Ping Test Mar 6, 2025
@achingbrain
Copy link
Member

The newly added interop tests are failing - please can you run the tests locally and push a fix.

Instructions of how to do this are in the readme.

Also: build instructions for electron should be added to the readme same as for browsers/node.

Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The newly added test run is causing CI to fail, this cannot be merged until CI passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

interop: add electron transport interop ping test
2 participants