Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow early muxer selection by connection encrypters #3022

Merged
merged 3 commits into from
Mar 3, 2025

Conversation

achingbrain
Copy link
Member

@achingbrain achingbrain commented Mar 3, 2025

Some encrypters allow sending application protocols along with the initial handshake.

We can use these to select muxers and save the round-trips of mss.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

Some encrypters allow sending application protocols along with the
initial handshake.

We can use these to select muxers and save the round-trips of mss.
@achingbrain achingbrain requested a review from a team as a code owner March 3, 2025 09:56
@2color
Copy link
Contributor

2color commented Mar 3, 2025

Would this save a roundtrip only for transports that don't have their own stream multiplexer, like TCP and WebSockets?

@achingbrain
Copy link
Member Author

achingbrain commented Mar 3, 2025

That's correct, yes. Transports like WebRTC and WebTransport skip the encryption/muxer part of the connection upgrade since they have their own strong opinions about how to perform these.

@achingbrain achingbrain merged commit dd71d8a into main Mar 3, 2025
33 checks passed
@achingbrain achingbrain deleted the feat/allow-early-muxer-selection branch March 3, 2025 12:15
@achingbrain achingbrain mentioned this pull request Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants