Skip to content

feat: allow early muxer selection by connection encrypters#3022

Merged
achingbrain merged 3 commits into
mainfrom
feat/allow-early-muxer-selection
Mar 3, 2025
Merged

feat: allow early muxer selection by connection encrypters#3022
achingbrain merged 3 commits into
mainfrom
feat/allow-early-muxer-selection

Conversation

@achingbrain

@achingbrain achingbrain commented Mar 3, 2025

Copy link
Copy Markdown
Member

Some encrypters allow sending application protocols along with the initial handshake.

We can use these to select muxers and save the round-trips of mss.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

Some encrypters allow sending application protocols along with the
initial handshake.

We can use these to select muxers and save the round-trips of mss.
@achingbrain achingbrain requested a review from a team as a code owner March 3, 2025 09:56
@2color

2color commented Mar 3, 2025

Copy link
Copy Markdown
Contributor

Would this save a roundtrip only for transports that don't have their own stream multiplexer, like TCP and WebSockets?

@achingbrain

achingbrain commented Mar 3, 2025

Copy link
Copy Markdown
Member Author

That's correct, yes. Transports like WebRTC and WebTransport skip the encryption/muxer part of the connection upgrade since they have their own strong opinions about how to perform these.

@achingbrain achingbrain merged commit dd71d8a into main Mar 3, 2025
@achingbrain achingbrain deleted the feat/allow-early-muxer-selection branch March 3, 2025 12:15
@achingbrain achingbrain mentioned this pull request Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants