Repository navigation
fix(webrtc): allocate UDP ports and clean up failed listeners - #3630
Merged
tabcat merged 11 commits intoOct 19, 2026
Merged
Conversation
Member
|
i'd like to open some pulls upstream so ephemeral ports could be reserved there, as that would be the correct fix, but this is a good solution until then. will review soon |
Contributor
Author
|
Fixed the Windows collision fixture in f25543d: bind the blocker to No production change, platform skip, timeout increase or test retry. All 17 focused tests pass locally with natural process exit; the failed-start regression still fails against original production. Package-local typecheck, lint and spellcheck pass. Fresh CI must confirm Windows. |
…p-listener-20260912 Resolve to main's versions for the files changed by the protons pin commit, so this PR no longer changes them.
The native error is the same for every listen failure, so matching its message did not tell a collision from anything else.
This was referenced Oct 19, 2026
Merged
Member
|
@peerbit-org thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allocate WebRTC Direct's ephemeral ports using UDP instead of a TCP probe. Reselect only on native ephemeral-bind failure, bounded to five attempts; explicit-port failures still propagate. Remove the
get-portdependency.Unregister failed startups, record the actual allocated port, and allow
close()to finish when startup fails.Local validation: 17 listener/transport tests pass and exit naturally; all six new regressions fail against the original code. Firefox: 47 passing, 24 existing skips. Package-local typecheck and lint pass.
The full Node suite completes its assertions but retains the process on both baseline and fix; this is not counted as a clean lifecycle pass. Full CI remains required.
Includes #3629 and its #3628 build prerequisite; the UDP fix is a separate commit. #3627 tracks the pre-existing Floodsub browser exception.