Repository navigation
docs: correct queue capacity and dial overflow semantics - #3674
Merged
Merged
Conversation
Signed-off-by: fmtappendf <fmtappendf@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
docs: correct queue capacity and dial overflow semantics
Description
The queue documentation currently misstates two behaviors:
jobs actually reject with DialError when the queue is full; requests
that join existing dial jobs are still allowed.
includes both waiting and running jobs.
Update both comments and supply the required limit argument in the
onSizeLessThan example. No runtime behavior changes.
Notes & open questions
Change checklist