Repository navigation
docs: import FaultTolerance from @libp2p/interface - #3676
Open
imitater-dou wants to merge 1 commit into
Open
imitater-dou wants to merge 1 commit into
imitater-dou wants to merge 1 commit into
Conversation
The transport manager example in doc/CONFIGURATION.md imports `FaultTolerance` from `@libp2p/interface-transport`, a pre-monorepo package last published in 2023 (v4.0.3) that libp2p no longer depends on. The enum is exported from `@libp2p/interface` (packages/interface/src/transport.ts) and is what packages/libp2p/src/transport-manager.ts imports. Signed-off-by: ADou <ikun3.1415927@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The "Configuring Transport Manager" example in
doc/CONFIGURATION.mdimportsFaultTolerancefrom@libp2p/interface-transport. That is a pre-monorepo package whose last release was v4.0.3 in June 2023, and libp2p no longer depends on it. The enum is now exported from@libp2p/interface, which is also wherepackages/libp2p/src/transport-manager.tsimports it from. This PR changes the import in the example.Repro on
main:Notes & open questions
This is a docs-only, one-line change.
Change checklist