Repository navigation
Conversation
Author
|
Could someone approve the workflow runs? They're at |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
libp2p.listen(addrs)andlibp2p.unlisten(addrs)so a node can start listening afterstart(), e.g. on<relay>/p2p-circuitonce an app handshake with the relay is done.listenforwards to the transport manager.unlistencloses listeners whose requested or current address matches, so passing the same address you gave tolistenworks even for/tcp/0.Closes #3645
Notes & open questions
Getting a relay reservation again after the relay drops is
unlistenthenlisten. Happy to rename or move this if you'd rather it lived elsewhere.Change checklist