Repository navigation
fix(gossipsub): cap prune backoff and process all prune entries - #3682
Merged
Merged
Conversation
Clamp the backoff accepted from a peer in a PRUNE message to one hour, matching rust-libp2p, and skip PRUNE entries for topics we are not meshed in instead of dropping the rest of the control message, matching go-libp2p and rust-libp2p. 🤖 Generated with AI assistance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
fix(gossipsub): cap prune backoff and process all prune entries
Description
Two small fixes in
handlePrune:clearBackoff. It is now clamped to one hour (GossipsubMaxPruneBackoff), matching rust-libp2p (MAX_REMOTE_PRUNE_BACKOFF_SECONDS = 3600).return, which dropped every remaining entry in the control message. It now usescontinue, matching go-libp2p and rust-libp2p.Notes & open questions
@types/sinonpinned to 22.0.0. 22.0.1 (published 2026-10-21) breaks type-checking of existing@libp2p/utilstests, which also shows up on current CI runs. That failure is unrelated to this change.npm run test:nodein packages/gossipsub passes (171 passing). The newprune.spec.tsfails on main and passes with this change.lint,dep-checkandspell-checkare clean.Change checklist
🤖 Generated with AI assistance