fix(gossipsub): Changed unsubscribe_backoff to expect Duration - #6124
Conversation
AgeManning
left a comment
There was a problem hiding this comment.
This change looks good to me.
Although you have linked an issue, can you please add a description and motivation for this PR.
This PR is what is primarily linked to the squashed commit and is what users will lookup in the history. All our PRs should have an accurate description and motivation.
|
Also, we need to modify the CHANGELOG in gossipsub, which is partially why CI is failing. Also this modifies the user-facing API and will need a version update to include it. |
AgeManning
left a comment
There was a problem hiding this comment.
Looks good to me. Will need a version bump to handle the API change.
elenaf9
left a comment
There was a problem hiding this comment.
Will need a version bump to handle the API change.
v0.50.0 is not released yet, so no version bump is needed. Only the changelog entry needs to be fixed.
Description
Gossipsub config back-off takes a duration as a number of seconds instead of
std::time::Duration, this PR fixes that.Fixes #6120
Notes & open questions
Allows using sub second and more specific unsubscribe_backoff times
Change checklist