Skip to content

fetch: Change identifier pb type from string to bytes #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fetch: Change identifier pb type from string to bytes #657

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions fetch/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

| Lifecycle Stage | Maturity | Status | Latest Revision |
|-----------------|----------------|--------|-----------------|
| 1A | Working Draft | Active | r1, 2019-08-13 |
| 1A | Working Draft | Active | r1, 2025-01-09 |

Authors: [@aschmahmann]

Expand Down Expand Up @@ -74,7 +74,7 @@ Should support: `Fetch(key) (value, statusCode)`
However, the level of specificity in the types of the above variables has wiggle room if people are interested.
The `go-libp2p-pubsub-router` implementation requires:

`key`: At least as generic as a UTF-8 string
`key`: At least as generic as a byte array that may be interpreted as a UTF-8 string

`value`: At least as generic as a byte array

Expand All @@ -91,7 +91,7 @@ The messages in the Fetch protocol use on of the following protobufs (proto3 syn
syntax = "proto2";

message FetchRequest {
string identifier = 1;
bytes identifier = 1;
}

message FetchResponse {
Expand Down Expand Up @@ -131,4 +131,4 @@ have cases where the payloads are tiny.

It could also be useful to have an aggregate version of this protocol where instead of fetching key-value pairs we fetch
sets of key-value pairs. This will be more efficient, much more when using a stream oriented transport, than running fetch
multiple times.
multiple times.