Add a armv6hf crossbuild target #184

ashthespy · 2018-03-07T01:52:16Z

This is mainly from plietar/librespot#202 with a few changes.
mainly, moved the raspberrypi-tools/ download into the Dockerfile so that it can be cached.

sashahilton00 · 2018-03-08T10:43:51Z

Can anyone else confirm this works? Don't have docker installed/set up to test this. @ComlOnline @awiouy

ComlOnline · 2018-03-08T11:41:00Z

Running it now.

ashthespy · 2018-03-08T12:17:48Z

Side note --
While this works with libasound2_1.0.25-4, I can't seem to compile successfully with the newer libasound2_1.1.3-5 version. The compiler complains about a missing ld-linux-armhf.so.3

 = note: /pi-tools/arm-bcm2708/gcc-linaro-arm-linux-gnueabihf-raspbian-x64/bin/../lib/gcc/arm-linux-gnueabihf/4.8.3/../../../../arm-linux-gnueabihf/bin/ld: warning: ld-linux-armhf.so.3, needed by /pi-tools/arm-bcm2708/arm-bcm2708hardfp-linux-gnueabi/arm-bcm2708hardfp-linux-gnueabi/sysroot/usr/lib/arm-linux-gnueabihf/libasound.so, not found (try using -rpath or -rpath-link)
          /pi-tools/arm-bcm2708/arm-bcm2708hardfp-linux-gnueabi/arm-bcm2708hardfp-linux-gnueabi/sysroot/usr/lib/arm-linux-gnueabihf/libasound.so: undefined reference to `__poll_chk@GLIBC_2.16'

This happens even when I link it with ln -s ld-linux.so.3 $SYSROOT/lib/ld-linux-armhf.so.3
Any ideas?

kingosticks · 2018-03-08T12:35:58Z

I did a similar cleanup and ended up with https://github.com/kingosticks/librespot/blob/rpi-docker/contrib/docker-build-pi-armv6hf.sh but i like your dkpg -x trick, much neater.

Looks like libasound2_1.0.25-4 requires GLIBC 2.16 but the sysroot has glibc 2.13 to remain compatible with Debian Wheezy (which is desirable).

sashahilton00 · 2018-03-08T12:36:01Z

Will try compiling later.

sashahilton00 · 2018-03-08T12:41:20Z

Also there's a typo @ashthespy you need to run the command docker run -v /tmp/librespot-build:/build librespot-cross contrib/docker-build-pi-armv6hf.sh

ashthespy · 2018-03-08T12:54:43Z

I did a similar cleanup and ended up with https://github.com/kingosticks/librespot/blob/rpi-docker/contrib/docker-build-pi-armv6hf.sh but i like your dkpg -x trick, much neater.

Ah - nice! Likewise for the loop ;-) my shell scripting know-how is still neweb level. Would you mind if mash yours in here as well?

Looks like libasound2_1.0.25-4 requires GLIBC 2.16 but the sysroot has glibc 2.13 to remain compatible with Debian Wheezy (which is desirable).

You mean libasound2_1.1.3-5 requires GLIBC 2.16 right, 1.0.25-4 works fine so far.
I didn't really look into alsa's changelog to see if there is any benefit of udating from 1.0.25-4 - don't fix what is not broken policy?

Also there's a typo @ashthespy you need to run the command docker run -v /tmp/librespot-build:/build librespot-cross contrib/docker-build-pi-armv6hf.sh

Oops, sorry!

kingosticks · 2018-03-08T13:00:59Z

You mean libasound2_1.1.3-5 requires GLIBC 2.16 right,

Yep! That's exactly what I meant to say. I agree: if it's not broke, don't fix it.

Feel free to mash.

sashahilton00 · 2018-03-08T13:03:08Z

Yup, lets just leave alsa at the current version. If you could push a commit to correct that typo, I'll merge this.

ComlOnline · 2018-03-08T13:20:14Z

I'm getting a permission denied error when running it at the moment, but I think that could just be my setup. Ill keep digging.

ashthespy · 2018-03-08T13:30:45Z

I'm getting a permission denied error when running it at the moment, but I think that could just be my setup. Ill keep digging.

FWIW: I use docker on windows and as it says:

Successfully tagged librespot-cross:latest
SECURITY WARNING: You are building a Docker image from Windows against a non-Windows Docker host. 
All files and directories added to build context will have '-rwxr-xr-x' permissions. 
It is recommended to double check and reset permissions for sensitive files and directories.

Dunno if this is causing issues?

ComlOnline · 2018-03-08T14:05:18Z

This is the exact error I'm getting

user@docker3-vm:~/gits/librespot$ docker run -v /tmp/librespot-build:/build librespot-cross contrib/docker-build-pi-armv6hf.sh
docker: Error response from daemon: OCI runtime create failed: container_linux.go:296: starting container process caused "exec: \"contrib/docker-build-pi-armv6hf.sh\": permission denied": unknown.
ERRO[0000] error waiting for container: context canceled

I have a few hours of work to do before I can look again but like I said it could just be my environment.

ashthespy · 2018-03-08T14:09:07Z

Oh dang. it should be /src/contrib/docker-build-pi-armv6hf.sh meh.
So docker run -v /tmp/librespot-build:/build /src/contrib/librespot-cross docker-build-pi-armv6hf.sh

sashahilton00 · 2018-03-08T14:23:33Z

@ashthespy it shouldn't be /src/contrib/docker-build-pi-armv6hf.sh the complete command would be docker run -v /tmp/librespot-build:/build librespot-cross contrib/docker-build-pi-armv6hf.sh

@ComlOnline thats a problem with your docker environment.

ComlOnline · 2018-03-08T14:25:11Z

@sashahilton00 I thought as much. More troubleshooting to be done on my end.

ashthespy · 2018-03-08T14:36:48Z

@ashthespy it shouldn't be /src/contrib/docker-build-pi-armv6hf.sh the complete command would be docker run -v /tmp/librespot-build:/build librespot-cross contrib/docker-build-pi-armv6hf.sh

Right - glossed over the WORKDIR /src line in the Dockerfile.
Should I revert this? Or close and submit a new pull request with a cleaner tree?

kingosticks · 2018-03-08T14:37:54Z

Just commit a fix and squash it (force pushing PR branches is fine)

ashthespy · 2018-03-09T17:55:22Z

@ComlOnline did you manage to trace down your issue?

ComlOnline · 2018-03-10T00:42:08Z

I've got it!
The new file is not executable!

Edit: The above commit should have fixed it.

ashthespy · 2018-03-10T00:49:43Z

I switch b/w windows and windows sub system for linux -- sorry!

ComlOnline · 2018-03-10T00:52:01Z

No worries, its happened to me too many times. :( I think I may have undone your previous commit in the process though.

ashthespy · 2018-03-10T01:02:48Z

 contrib/docker-build-pi-armv6hf.sh 100644 → 100755

looks good to me?
TBH, I recently changed my git config to git config core.filemode false but will turn it back on now!

ComlOnline · 2018-03-10T01:07:15Z

Thats what I thought, ~~but notice it says two files modified~~ and the docker command is docker run -v /tmp/librespot-build:/build contrib/librespot-cross docker-build-pi-armv6hf.sh again. With the contrib/ in the wrong place :/

Edit: Learning little things about github still.

ashthespy · 2018-03-10T01:52:12Z

I can fix permissions , squash and force push if you'd like to keep a clean tree?

ComlOnline · 2018-03-10T01:53:37Z

Squashing it works for me.

sashahilton00 · 2018-03-10T01:54:35Z

Yup squash and once tested will merge.

ashthespy · 2018-03-10T03:15:11Z

I am lost - I just pulled my branch from 40d7960 and the file seems to already have the 755 permissions? I'm guessing the Coml's branch was tracking the old commit that was squashed? Can someone counter check?

EDIT: nvm. windows is a pain with shell scripts.

I also found git update-index --chmod=+x <file> that will ensure I don't make such a mess again!

ashthespy · 2018-03-10T15:20:57Z

Okay, everything looks good from my side - can be merged when tested :-)

sashahilton00 · 2018-03-10T17:06:59Z

@ashthespy the command is still wrong. docker run -v /tmp/librespot-build:/build librespot-cross contrib/docker-build-pi-armv6hf.sh is what it should be.

Tweak `armv6hf` crossbuild script Fix example typo in Dockerfile Changed File permissions

ComlOnline · 2018-03-10T19:39:52Z

Looks good to me. Ill merge it in a few hours unless anyone has a problem. :) Thanks @ashthespy

Add a armv6hf crossbuild target

ashthespy force-pushed the armv6hf branch from bf0f846 to 530af96 Compare March 8, 2018 13:39

ashthespy force-pushed the armv6hf branch from 22af679 to 40d7960 Compare March 8, 2018 15:01

ashthespy force-pushed the armv6hf branch from 9856147 to e395c23 Compare March 10, 2018 15:19

Add a armv6hf crossbuild target

24cd9aa

Tweak `armv6hf` crossbuild script Fix example typo in Dockerfile Changed File permissions

ashthespy force-pushed the armv6hf branch from e395c23 to 24cd9aa Compare March 10, 2018 18:10

ComlOnline merged commit 9d9c311 into librespot-org:master Mar 11, 2018

ashthespy deleted the armv6hf branch March 18, 2018 12:21

ashthespy mentioned this pull request Nov 6, 2019

add script to build for Raspberry Pi 1 and Zero in docker image #63

Closed

paulfariello pushed a commit to paulfariello/librespot that referenced this pull request Sep 23, 2025

Merge pull request librespot-org#184 from ashthespy/armv6hf

e2df632

Add a armv6hf crossbuild target

Add a armv6hf crossbuild target #184

Add a armv6hf crossbuild target #184

Uh oh!

Conversation

ashthespy commented Mar 7, 2018

Uh oh!

sashahilton00 commented Mar 8, 2018

Uh oh!

ComlOnline commented Mar 8, 2018

Uh oh!

ashthespy commented Mar 8, 2018

Uh oh!

kingosticks commented Mar 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sashahilton00 commented Mar 8, 2018

Uh oh!

sashahilton00 commented Mar 8, 2018

Uh oh!

ashthespy commented Mar 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kingosticks commented Mar 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sashahilton00 commented Mar 8, 2018

Uh oh!

ComlOnline commented Mar 8, 2018

Uh oh!

ashthespy commented Mar 8, 2018

Uh oh!

ComlOnline commented Mar 8, 2018

Uh oh!

ashthespy commented Mar 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sashahilton00 commented Mar 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ComlOnline commented Mar 8, 2018

Uh oh!

ashthespy commented Mar 8, 2018

Uh oh!

kingosticks commented Mar 8, 2018

Uh oh!

ashthespy commented Mar 9, 2018

Uh oh!

ComlOnline commented Mar 10, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ashthespy commented Mar 10, 2018

Uh oh!

ComlOnline commented Mar 10, 2018

Uh oh!

ashthespy commented Mar 10, 2018

Uh oh!

ComlOnline commented Mar 10, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ashthespy commented Mar 10, 2018

Uh oh!

ComlOnline commented Mar 10, 2018

Uh oh!

sashahilton00 commented Mar 10, 2018

Uh oh!

ashthespy commented Mar 10, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ashthespy commented Mar 10, 2018

Uh oh!

sashahilton00 commented Mar 10, 2018

Uh oh!

ComlOnline commented Mar 10, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

kingosticks commented Mar 8, 2018 •

edited

Loading

ashthespy commented Mar 8, 2018 •

edited

Loading

kingosticks commented Mar 8, 2018 •

edited

Loading

ashthespy commented Mar 8, 2018 •

edited

Loading

sashahilton00 commented Mar 8, 2018 •

edited

Loading

ComlOnline commented Mar 10, 2018 •

edited

Loading

ComlOnline commented Mar 10, 2018 •

edited

Loading

ashthespy commented Mar 10, 2018 •

edited

Loading