3DS: enable mbedTLS #17762
Open
3DS: enable mbedTLS #17762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While here: * remove input_overlay and task_overlay from linking blacklist * move -Werror to CC invocation since C++ refuses to use it * copy the quiet build mode from the main Makefile and make it the default * temporarily define DEPRECATED for gpu_old.h to allow succesful build * replace the call to command_event() with one to retroarch_main_quit() in a failure case
pstef
force-pushed
the
ctr-mbedtls
branch
2 times, most recently
from
a83d7db to
ad70b05
Compare
|
I guess we could try merging it and if you notice issues on the buildbot nightlies you can take it from there? But hopefully everything works out fine |
|
I believe the image needs to be updated before this goes in. As it stands, the wrong type is chosen - which is what the warnings are about. |
|
I've found a workaround and believe this can go in, but it's based upon #17753 which resolves the name collision on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my eyes this is ready, but generates warnings on libretro's CI. I suspect devkitARM there is too old and its sys/socket.h doesn't define _SOCKLEN_T_DECLARED, which deps/mbedtls/net_sockets.c expects. My devkitARM is fresher and here there are no warnings about type_len being of type int instead of socklen_t.