Arm fixes #134
Closed
Arm fixes #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed from logical OR (||) to bitwise OR (|) for checking if the 64-bit multiply result is zero. While both operators produce the same final boolean result when both operands are zero or non-zero, the bitwise OR is the correct operation for combining register values to check if the complete 64-bit result (high 32 bits | low 32 bits) equals zero. Applies to long multiply instructions: UMULLS, UMLALS, SMULLS, SMLALS
This change replaces the runtime initialization with a precomputed constexpr table of 256 entries, providing the same values at compile time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.