-
Notifications
You must be signed in to change notification settings - Fork 8
Implementation of BMat16 #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Closing and reopening to trigger the ci again |
1591168 to
76df096
Compare
james-d-mitchell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried BMat16's with libsemigroups (basically dropping it in everywhere we use HPCombi::BMat8 in the tests) and found no issues whatsoever. So I'm happy to merge this if you are @hivert ?
I'd like to look a little at the generated assembly code to check that some think are properly optimized by the (a) compiler (notably some product by power of 2 which could be written as shift). I try to do it either during the week-end or next week. Other than that, I'm Ok to merge. |
fbd8def to
84cef85
Compare
|
The code looks good. I checked:
This should be fixed easily
There are finally some possible improvements which needs to be fixed:
|
|
Great! Thanks @hivert, should we then: merge this PR, and add issues for the TODOs that you mention, or would you rather that the TODOs are addressed in this PR first? |
|
I just rebased onto the most recent versions on |
Here are the additions regarding BMat16 :