Remove shadow declarations #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit renames some of the variables from the constructors of PTransf16 and its derived classes from "v" to "vv". The reason for doing this is that there is a data member of Vect16 named "v", and compiling with warnings enabled complains that the variables "v" shadowed the data member "v".
james-d-mitchell
added a commit
to james-d-mitchell/libsemigroups
that referenced
this pull request
Mar 4, 2025
…ings Except those in stephen.hpp to just not collide with what RC is doing. There are some warnings arising in HPCombi, which I've fixed in: libsemigroups/HPCombi#52 But there'll need to be a release of HPCombi, and we'll need to include that released version, before those warnings will go away.
james-d-mitchell
added a commit
to james-d-mitchell/libsemigroups
that referenced
this pull request
Mar 4, 2025
…ings Except those in stephen.hpp to just not collide with what RC is doing. There are some warnings arising in HPCombi, which I've fixed in: libsemigroups/HPCombi#52 But there'll need to be a release of HPCombi, and we'll need to include that released version, before those warnings will go away.
james-d-mitchell
added a commit
to james-d-mitchell/libsemigroups
that referenced
this pull request
Mar 5, 2025
…ings Except those in stephen.hpp to just not collide with what RC is doing. There are some warnings arising in HPCombi, which I've fixed in: libsemigroups/HPCombi#52 But there'll need to be a release of HPCombi, and we'll need to include that released version, before those warnings will go away.
Collaborator
|
I guess I don't need to review the code anymore ;-) Anyways, the changes looked good... |
james-d-mitchell
added a commit
to libsemigroups/libsemigroups
that referenced
this pull request
Mar 5, 2025
* Fix clang compile warnings * Fix compile warnings with gcc-14 * Fix warnings exposed by --enable-compile-warnings & g++-14 * Fix warnings in tests exposed by --enable-compile-warnings & clang * Fix all compile warnings coming from g++-14 and --enable-compile-warnings Except those in stephen.hpp to just not collide with what RC is doing. There are some warnings arising in HPCombi, which I've fixed in: libsemigroups/HPCombi#52 But there'll need to be a release of HPCombi, and we'll need to include that released version, before those warnings will go away. * Formatting * Fix for last * Update tests/test-froidure-pin-transf.cpp Co-authored-by: Joe Edwards <[email protected]> * Suppress -Wundef for backward * include config.hpp in third_party wrappers * Update HPCombi to 1.0.2 * Update pragmas for HPCombi * Add -Wswitch-default for eigen --------- Co-authored-by: Joe Edwards <[email protected]> Co-authored-by: Joseph Edwards <[email protected]>
Member
Author
|
Sorry @hivert I should have waited! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit renames some of the variables from the constructors of PTransf16 and its derived classes from "v" to "vv". The reason for doing this is that there is a data member of Vect16 named "v", and compiling with warnings enabled complains that the variables "v" shadowed the data member "v".