Fix compile warnings #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmake now issues warnings about not supporting versions < 3.10, so bumping min. to 3.10.
james-d-mitchell
force-pushed
the
fix-compile-warnings
branch
from
9fbf33a to
81a8815
Compare
Member
Author
|
@hivert if you have the chance to check that you're okay with these changes that'd be great, if you don't have time, no worries. |
Contributor
Joseph-Edwards
left a comment
Joseph-Edwards
left a comment
There was a problem hiding this comment.
Other than a potentially erroneous comment, all of these changes seem reasonable to me.
Joseph-Edwards
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm in the process of updating
libsemigroupsto use HPCombi v1.1.0, and I noticed that there were a bunch of compiler warnings generated by code added between v1.0.1 and v1.1.0 (nothing major). I've fixed those in this PR.