Skip to content

Conversation

enginelesscc
Copy link
Contributor

@enginelesscc enginelesscc commented Sep 20, 2025

This fixes building LTC_AES_NI on msvc, keeps compat with clang-cl

Checklist

  • ran tests (locally)

@enginelesscc
Copy link
Contributor Author

I see no [intended] path where I could extend the CI to run with LTC_AES_NI enabled.
What do we do there?
- enable aesni by default on msvc's makefile?
- or hardcode the flag in the appveyor.yml?

@sjaeckel
Copy link
Member

sjaeckel commented Oct 3, 2025

I see no [intended] path where I could extend the CI to run with LTC_AES_NI enabled.
What do we do there?

  • enable aesni by default on msvc's makefile?
  • or hardcode the flag in the appveyor.yml?

I see two options

  • having another build&test step in the appveyor with AESNI enabled
  • adding github actions on Windows support which also provides MSVC IIUC

I guess the first one would be the easiest!?

Copy link
Member

@sjaeckel sjaeckel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the patch works as intended!

Thanks :)

@sjaeckel sjaeckel merged commit b1fa61d into libtom:develop Oct 6, 2025
79 checks passed
@sjaeckel sjaeckel added this to the next milestone Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants