Skip to content

Conversation

@vgorkavenko
Copy link
Contributor

No description provided.

import "../libraries/EVMScriptCreator.sol";
import "../interfaces/IEVMScriptFactory.sol";
import "../interfaces/INodeOperatorsRegistry.sol";
import "../interfaces/ICSModule.sol";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be IBaseModule.sol I guess

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. Will be used with this changes

Comment on lines 24 to 25
string private constant ERROR_SOURCE_OPERATOR_ID_OUT_OF_RANGE = "SOURCE_OPERATOR_ID_OUT_OF_RANGE";
string private constant ERROR_TARGET_OPERATOR_ID_OUT_OF_RANGE = "TARGET_OPERATOR_ID_OUT_OF_RANGE";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not exist?

input.sourceOperatorId,
false
);
require(msg.sender == rewardAddress, ERROR_CALLER_IS_NOT_SOURCE_OPERATOR_OWNER);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this enforce enactment by the SourceNO Owner only?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. Added comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants