-
Notifications
You must be signed in to change notification settings - Fork 8
[CMv2] feat: owner allowance factory for consolidation #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
[CMv2] feat: owner allowance factory for consolidation #102
Conversation
| import "../libraries/EVMScriptCreator.sol"; | ||
| import "../interfaces/IEVMScriptFactory.sol"; | ||
| import "../interfaces/INodeOperatorsRegistry.sol"; | ||
| import "../interfaces/ICSModule.sol"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be IBaseModule.sol I guess
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. Will be used with this changes
| string private constant ERROR_SOURCE_OPERATOR_ID_OUT_OF_RANGE = "SOURCE_OPERATOR_ID_OUT_OF_RANGE"; | ||
| string private constant ERROR_TARGET_OPERATOR_ID_OUT_OF_RANGE = "TARGET_OPERATOR_ID_OUT_OF_RANGE"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not exist?
| input.sourceOperatorId, | ||
| false | ||
| ); | ||
| require(msg.sender == rewardAddress, ERROR_CALLER_IS_NOT_SOURCE_OPERATOR_OWNER); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this enforce enactment by the SourceNO Owner only?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. Added comment
No description provided.