Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix npm release №2: use .npmrc #122

Merged
merged 4 commits into from
Sep 9, 2024

Conversation

alx-khramov
Copy link
Contributor

#121 didn't help: https://github.com/lidofinance/lido-js-sdk/actions/runs/10772693898

This PR is an attempt to fix npm publish by moving the config into .npmrc

@alx-khramov alx-khramov requested a review from a team September 9, 2024 13:08
@alx-khramov alx-khramov self-assigned this Sep 9, 2024
@alx-khramov alx-khramov requested a review from a team as a code owner September 9, 2024 14:49
rnmsslido
rnmsslido previously approved these changes Sep 9, 2024
Copy link

@rnmsslido rnmsslido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@rnmsslido rnmsslido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alx-khramov alx-khramov merged commit 79eeb22 into main Sep 9, 2024
3 checks passed
@alx-khramov alx-khramov deleted the fix-deploy-workspaces-update-false-npmrc branch September 9, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants