Skip to content

LPD-62912 Add support for Microsoft SQL Server 2022 #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Oct 13, 2025
Merged

LPD-62912 Add support for Microsoft SQL Server 2022 #131

Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
6893818
LPD-62912 Add configs for SQL Server
anthony-chu Sep 30, 2025
441b2c9
LPD-62912 Include SQL Server JDBC jar in bundle
anthony-chu Sep 30, 2025
3f76e26
LPD-62912 Reuse DB2 database results for SQL Server
anthony-chu Sep 30, 2025
020f54d
LPD-62912 Add recipe files for SQL Server
anthony-chu Sep 30, 2025
730a4f4
LPD-62912 Optionally change ownership for SQL Server files in data-he…
anthony-chu Sep 30, 2025
bd54b02
LPD-62912 Expose property for SQL Server
anthony-chu Sep 30, 2025
9829c00
LPD-62912 Update README
anthony-chu Sep 30, 2025
1fe39ac
LPD-62912 Copy as root
anthony-chu Sep 30, 2025
9473df8
LPD-62912 Using busybox is sufficient
anthony-chu Sep 30, 2025
6b87728
LPD-62912 Convert to elif statements
anthony-chu Oct 1, 2025
1bf9e94
LPD-62912 Add restore to entrypoint
anthony-chu Oct 1, 2025
531744d
LPD-62912 Update condition
anthony-chu Oct 1, 2025
4f8a859
LPD-62912 Add config for database type
anthony-chu Oct 1, 2025
c73b844
LPD-62912 Consolidate jdbc driver tasks into one
anthony-chu Oct 1, 2025
f196aea
LPD-62912 Add missing MariaDB config for consistency
anthony-chu Oct 1, 2025
630271b
LPD-62912 Run copy task conditionally
anthony-chu Oct 1, 2025
f6ce535
LPD-62912 Add mssql jdbc jar to .gitignore
anthony-chu Oct 1, 2025
c1c5f01
LPD-62912 uses the configuration itself to conditionally run the task
drewbrokke Oct 2, 2025
53a0b8f
LPD-62912 Ensure dump is owned by mssql user when using SQL Server
anthony-chu Oct 8, 2025
4b2d942
LPD-62912 Ensure column name is single quoted to avoid keyword
anthony-chu Oct 8, 2025
e631132
LPD-62912 Include backup file for sql server
anthony-chu Oct 8, 2025
44dbd38
LPD-62912 Fix backup file path
anthony-chu Oct 8, 2025
467a68b
LPD-62912 Return empty map if no results are found
anthony-chu Oct 8, 2025
54254f6
LPD-62912 Fix database file location
anthony-chu Oct 8, 2025
d2e5d00
LPD-62912 Fix health check
anthony-chu Oct 8, 2025
70538d9
LPD-62912 Use early returns
anthony-chu Oct 8, 2025
7ae54a9
LPD-62912 Make entrypoint echos clearer
anthony-chu Oct 8, 2025
1736a2d
LPD-62912 Fix DB type
anthony-chu Oct 9, 2025
cdd3244
LPD-62912 Field not used
anthony-chu Oct 9, 2025
121e76c
LPD-62912 Add missing documentation
anthony-chu Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions buildSrc/src/main/groovy/docker-database-saas.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ ext {
disableUserObjectValidations = {
String schema ->

executeSQLQuery("update ObjectValidationRule set active_ = false where objectDefinitionId in (select objectDefinitionId from ObjectDefinition where externalReferenceCode = 'L_USER')", schema)
executeSQLQuery("update ObjectValidationRule set active_ = 'false' where objectDefinitionId in (select objectDefinitionId from ObjectDefinition where externalReferenceCode = 'L_USER')", schema)
Copy link
Member

@drewbrokke drewbrokke Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this issue observed? Is this backwards compatible with other database types?

Copy link
Member Author

@anthony-chu anthony-chu Oct 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initially, it gives a unhelpful exception:

java.lang.IndexOutOfBoundsException: Index 1 out of bounds for length 1

this comes from the attempt to parse the results of the executed sql query. printing out the actual bare result that comes back from the query, the following response is given:

[Msg 207, Level 16, State 1, Server 804fb429fda5, Line 1, Invalid column name 'false'.]

for SQL Server, false is a reserved keyword. in order to be used as a string, it needs to be quoted.

i had not tested it for other databases. i did just now, and other databases don't accept the single-quotes around false, so added a check for the database to determine which sql statement to use.

i'll send a follow-up PR to address the other DBs.


println "Disabled object validation users for User system object in schema ${schema}"
}
Expand Down Expand Up @@ -253,7 +253,7 @@ ext {

sanitizePortalPreferenceValues(schema, sanitizedPreferences)

executeSQLQuery("update MBMailingList set inServerName = 'fake-pop3-host', outServerName = 'fake-smtp-host', inPassword = 'fake-pop3-password', outPassword = 'fake-smtp-password', active_ = false", schema)
executeSQLQuery("update MBMailingList set inServerName = 'fake-pop3-host', outServerName = 'fake-smtp-host', inPassword = 'fake-pop3-password', outPassword = 'fake-smtp-password', active_ = 'false'", schema)

println "Sanitized known POP and SMTP configurations in schema ${schema}"
}
Expand Down