chore(examples): update rainbowkit and dynamic examples #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomiiide
commented
Mar 6, 2025
tomiiide
commented
Mar 7, 2025
chybisov
changed the title
chybisov
requested changes
Mar 13, 2025
chybisov
requested changes
Mar 20, 2025
examples/dynamic/package.json
Outdated
| @@ -25,7 +25,8 @@ | |||
| "react": "^19.0.0", | |||
| "react-dom": "^19.0.0", | |||
| "viem": "^2.23.10", | |||
| "wagmi": "^2.14.13" | |||
| "wagmi": "^2.14.13", | |||
| "vite-plugin-env-compatible": "^2.0.1" | |||
There was a problem hiding this comment.
Why do we need this? Other examples seems to work fine without it
There was a problem hiding this comment.
The dynamic sdk is trying to access an env variable this way, we need this to make vite compatible with process.env
chybisov
reviewed
Mar 31, 2025
| return wallet.connector as SolanaWalletConnector | ||
| } | ||
| } | ||
|
|
||
| export const SolanaDynamicHandler: FC = () => { |
There was a problem hiding this comment.
Let's rename SolanaDynamicHandler to DynamicSolanaProvider
chybisov
reviewed
Mar 31, 2025
|
|
||
| handleConnectedSolanaWallet() | ||
| }, [solanaWallet, select, wallets]) | ||
|
|
||
| return null |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira task is linked to this PR?
LF-8689
Why was it implemented this way?
Visual showcase (Screenshots or Videos)
-N/A-
Checklist before requesting a review