Add support to build remill on windows with static CRT.#752
Merged
kyle-elliott-tob merged 1 commit intolifting-bits:masterfrom Feb 13, 2026
Merged
Add support to build remill on windows with static CRT.#752kyle-elliott-tob merged 1 commit intolifting-bits:masterfrom
kyle-elliott-tob merged 1 commit intolifting-bits:masterfrom
Conversation
|
|
EinTim23
changed the title
Contributor
|
based and msvc-pilled? MSVC isn't supported for remill though... |
Contributor
Author
|
It does affect builds made using clang-cl as well. CMake docs on this topic: "This variable has effect only when policy CMP0091 is set to NEW prior to the first project() or enable_language() command that enables a language using a compiler targeting the MSVC ABI." |
Ninja3047
approved these changes
Feb 13, 2026
Collaborator
Ninja3047
left a comment
Ninja3047
left a comment
There was a problem hiding this comment.
lgtm, just waiting for CI to go through
Collaborator
|
Ty! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support controlling the wanted CRT on windows using CMAKE_MSVC_RUNTIME_LIBRARY.