Drop python2 support and fix setup.py install #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code removed was only necessary to support Python 2. Furthermore, because setuptools no longer support use_2to3, the code became a problem for installation procedures that use setuptools, such as pip. This should fix a few issues related to the installation procedures.
This commit removes distutils code in setup.py. The distutils package is deprecated and slated for removal in Python 3.12. The removal of this code doesn't affect the installation procedures, using pip.
|
It would be really cool if this could be merged. I use pyminifier in a project and I need to either bundle the relevant pyminifier files or find another obfuscation/minifier library if it cannot be installed on python 3.10/3.11. |
|
👍 to getting this merged and fixing the issue. |
|
Given that the original author hasn't been seen on GitHub since 2018, I suggest that you try emailing him asking for a transfer of ownership of the GitHub repo and the PyPI project. If you get no response then fork this repo and submit a pep541 name transfer request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes dropping Python 2 support to fix problems with setup.py. It also drops use of distutils as it is slated for removal in Python 3.12. The changes are minimal and do not break the tests (neither the repo tests, nor manual tests I performed myself with data on my own use of pyminifier).