- 
                Notifications
    
You must be signed in to change notification settings  - Fork 639
 
feat: add SCIM role controller and service for role-based access management #17806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
          
 This stack of pull requests is managed by Graphite. Learn more about stacking.  | 
    
| 
           Your preview environment pr-17806 has been deployed. Preview environment endpoints are available at:  | 
    
| 
           Preview environment logs can be accessed at: https://console.cloud.google.com/logs/query;query=resource.labels.namespace_name%3D%22pr-17806%22;duration=PT30M?project=lightdash-previews  | 
    
| 
           You can ssh into the preview environment by running:   | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Just one non-blocking question.
| totalResults: filteredRoles.length, | ||
| }); | ||
| 
               | 
          ||
| return { | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be worth making ScimListResult a class to make the response easier to form? I know TS will flag unknown fields, but the DX might improve from having a shared function to create these objects if they're all standard.
# [0.2132.0](0.2131.4...0.2132.0) (2025-11-04) ### Features * add SCIM role controller and endpoints ([#17806](#17806)) ([25ee079](25ee079))
| 
           🎉 This PR is included in version 0.2132.0 🎉 The release is available on: 
 Your semantic-release bot 📦🚀  | 
    

Closes: #SCIM-roles-support
Description:
This PR adds SCIM role support to enable identity providers to discover and retrieve Lightdash roles through the SCIM API. The implementation includes:
ScimRoleControllerwith endpoints to list roles and get a specific roleThis enhancement allows identity providers to map their roles to Lightdash roles during user provisioning, improving the SCIM integration experience.
Next PR will also return project roles.
List roles

Get role

List resource types

Get resource type

List schemas

Get schema
