update solid not to double work #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterlucas
reviewed
Jun 27, 2025
frameworks/solid/src/benchmark.jsx
Outdated
| }} | ||
| </For> | ||
| <Index each={data()}>{(row) => ( | ||
| <view x={row().x} y={row().y} width={row().width} height={row().height} color={row().color}> |
Contributor
There was a problem hiding this comment.
Youre using View all over your example app - similar for Text vs text ... sounds like this is not respective of what you would use in a real app.
wouterlucas
requested changes
Jun 27, 2025
Contributor
wouterlucas
left a comment
wouterlucas
left a comment
There was a problem hiding this comment.
Please keep usage of View and Text otherwise looks good.
Contributor
Author
|
We've been moving away from using the component and and moving towards just using raw and nodes. Most of the components now in solid just use lowercase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to latest solid release and fixed first creating an empty array, processing that, and then processing a new array forcing solid to do a lot of additional work.