Skip to content

Conversation

@jfboeve
Copy link
Collaborator

@jfboeve jfboeve commented Feb 20, 2025

Changes:

  • Added new shader attributes
  • Added config to app launch to import your own shader types
  • Removed effects attribute
  • Removed this.shader function related to effects

TODO:

  • Documentation
  • Update package.json when renderer 3.0 is released

@jfboeve jfboeve marked this pull request as draft February 20, 2025 09:35
Copy link
Collaborator

@michielvandergeest michielvandergeest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great so far!

Left some comments below

import { renderer } from './launch.js'

export default () => {
function registerBlitsDefaultShaders(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we really need a separate named function for this? we can run the shManager.registerShaderType('rounded', Rounded) commands directly in the async function I think (see also comments below about moving it outside of the if/else

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved this with a better solution.. has some issues with vite not liking dynamic import url's.

@github-actions
Copy link

Test Results Summary: (Ran at: Thu Mar 20 08:25:57 UTC 2025)
passed: 505 failed: 3 of 508 tests (810ms)

@github-actions
Copy link

Test Results Summary: (Ran at: Thu Mar 20 14:20:19 UTC 2025)
passed: 505 failed: 3 of 508 tests (792ms)

@github-actions
Copy link

Test Results Summary: (Ran at: Fri Mar 21 13:55:30 UTC 2025)
passed: 310 failed: 58 of 368 tests (805ms)

@github-actions
Copy link

Test Results Summary: (Ran at: Fri Mar 21 14:17:19 UTC 2025)
passed: 310 failed: 58 of 368 tests (789ms)

@github-actions
Copy link

Test Results Summary: (Ran at: Tue Mar 25 09:35:37 UTC 2025)
passed: 310 failed: 58 of 368 tests (821ms)

@github-actions
Copy link

Test Results Summary: (Ran at: Thu Mar 27 14:25:39 UTC 2025)
passed: 310 failed: 58 of 368 tests (831ms)

uguraslan and others added 26 commits April 9, 2025 15:13
…age-function

Added stop function on speech utterance to allow developers to stop a…
Updates GitHub workflows for tests
Deletes unnecessary backup files for husky
…ssue

Addressed renderer package.json import issue in blits
Fixed issue where global watchers weren't properly cleared and were k…
…rent

Added trigger to update parent layout in the case of nested layout.
@michielvandergeest michielvandergeest changed the base branch from dev to feature/v2 April 16, 2025 12:40
@michielvandergeest michielvandergeest marked this pull request as ready for review April 16, 2025 12:43
Copy link
Collaborator

@michielvandergeest michielvandergeest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michielvandergeest michielvandergeest merged commit 47afd2e into feature/v2 Apr 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants