-
Notifications
You must be signed in to change notification settings - Fork 34
Feat/rc 3.0 #298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/rc 3.0 #298
Conversation
michielvandergeest
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great so far!
Left some comments below
| import { renderer } from './launch.js' | ||
|
|
||
| export default () => { | ||
| function registerBlitsDefaultShaders( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we really need a separate named function for this? we can run the shManager.registerShaderType('rounded', Rounded) commands directly in the async function I think (see also comments below about moving it outside of the if/else
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolved this with a better solution.. has some issues with vite not liking dynamic import url's.
|
Test Results Summary: (Ran at: Thu Mar 20 08:25:57 UTC 2025) |
|
Test Results Summary: (Ran at: Thu Mar 20 14:20:19 UTC 2025) |
|
Test Results Summary: (Ran at: Fri Mar 21 13:55:30 UTC 2025) |
|
Test Results Summary: (Ran at: Fri Mar 21 14:17:19 UTC 2025) |
|
Test Results Summary: (Ran at: Tue Mar 25 09:35:37 UTC 2025) |
|
Test Results Summary: (Ran at: Thu Mar 27 14:25:39 UTC 2025) |
… specific message.
…age-function Added stop function on speech utterance to allow developers to stop a…
Sets up linting checks
Updates GitHub workflows for tests
Deletes unnecessary backup files for husky
Release 1.27.0
Signed-off-by: Suresh Kumar Gangumalla <[email protected]>
…ssue Addressed renderer package.json import issue in blits
Fixed issue where global watchers weren't properly cleared and were k…
…rent Added trigger to update parent layout in the case of nested layout.
michielvandergeest
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Changes:
TODO: